Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PHPUnit attributes over annotations #495

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Use PHPUnit attributes over annotations #495

merged 1 commit into from
Aug 12, 2023

Conversation

BackEndTea
Copy link
Contributor

Since this project is PHPUnit 10, we might as well use the new attributes instead of the annotations

williamdes
williamdes approved these changes Aug 12, 2023
View reviewed changes
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@williamdes williamdes added this to the 6.0.0 milestone Aug 12, 2023
@codecov
Copy link

codecov bot commented Aug 12, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (10817ca) 96.61% compared to head (7eebef5) 96.61%.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #495   +/-   ##
=========================================
  Coverage     96.61%   96.61%           
  Complexity     2173     2173           
=========================================
  Files            66       66           
  Lines          5054     5054           
=========================================
  Hits           4883     4883           
  Misses          171      171

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BackEndTea
Copy link
Contributor Author

It seems psalm can't detect the dataproviders as being used with the attributes yet

@williamdes
Copy link
Member

It seems psalm can't detect the dataproviders as being used with the attributes yet

Let's say not a big deal, phpstan can do it
Maybe @MauricioFauth knows how to make psalm happy ?

Else, run composer run update:baselines

@BackEndTea
Use attributes over annotations for phpunit
7eebef5 
Since this project is PHPUnit 10, we might as well
use the new attributes instead of the annotations
@MauricioFauth
Copy link
Member

It seems psalm can't detect the dataproviders as being used with the attributes yet

Let's say not a big deal, phpstan can do it
Maybe @MauricioFauth knows how to make psalm happy ?

Else, run composer run update:baselines

The PHPUnit plugin for Psalm doesn't understand it yet.

@williamdes williamdes self-assigned this Aug 12, 2023
@williamdes williamdes merged commit 4843cbb into phpmyadmin:master Aug 12, 2023
12 checks passed
@williamdes
Copy link
Member

Thank you @BackEndTea !

@BackEndTea
Copy link
Contributor Author

Thanks @williamdes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamdes williamdes williamdes approved these changes

Assignees

@williamdes williamdes

Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@BackEndTea @williamdes @MauricioFauth